Skip to content

Conversation

apaszke
Copy link
Member

@apaszke apaszke commented Oct 10, 2025

No description provided.

@apaszke apaszke requested a review from superbobry October 10, 2025 14:06
os.environ["RANK"] = str(jax.process_index())
os.environ["WORLD_SIZE"] = str(jax.process_count())
os.environ["MASTER_ADDR"] = "localhost"
os.environ["MASTER_PORT"] = "5728"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use portpicker or similar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but unfortunately portpicker doesn't seem to return the same value in all shards, leading to hangs...


def test_remote_semaphore(self):
if dist.get_world_size() != 2:
self.skipTest("Test assumes 2 devics")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: devices.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Oct 10, 2025
@apaszke apaszke self-assigned this Oct 14, 2025
@copybara-service copybara-service bot merged commit 300431d into jax-ml:main Oct 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run pull ready Ready for copybara import and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants