[Pallas:MGPU] Add support for jnp.sin #33662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_839326194
branch
from
83c32e4 to
ad4dc33
Compare
PiperOrigin-RevId: 839326194
copybara-service
bot
force-pushed
the
test_839326194
branch
from
ad4dc33 to
24c2115
Compare
oulgen
reviewed
Dec 2, 2025
Comment on lines
+2304
to
+2316
| @register_lowering_rule(lax.sin_p, mgpu.LoweringSemantics.Lane) | ||
| @register_lowering_rule(lax.sin_p, mgpu.LoweringSemantics.Warpgroup) | ||
| def _sin_lowering_rule(ctx: LoweringRuleContext, x, accuracy): | ||
| if accuracy is not None: | ||
| raise NotImplementedError("Not implemented: accuracy") | ||
| [x_aval] = ctx.avals_in | ||
| if ctx.module_ctx.lowering_semantics == mgpu.LoweringSemantics.Lane: | ||
| return _ensure_fa(x, x_aval.dtype).sin(approx=ctx.module_ctx.approx_math) | ||
| fastmath = ( | ||
| arith_dialect.FastMathFlags.afn if ctx.module_ctx.approx_math else None | ||
| ) | ||
| return math_dialect.sin(_ensure_ir_value(x, x_aval.dtype), fastmath=fastmath) | ||
|
|
There was a problem hiding this comment.
so this is like a template for all the elementwise ops?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Pallas:MGPU] Add support for jnp.sin