Extend CI and local test coverage to MySQL and SQLite #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 33 33
Lines 1144 1144
=======================================
Hits 1096 1096
Misses 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2ykwang
force-pushed
the
support-postgrelsql-docker-test
branch
from
7c89136 to
0e8e90e
Compare
- Fix TRUNCATE command support detection for different databases - Add conditional PostgreSQL-specific model registration - Improve database-specific test skipping logic - Remove SQLite from TRUNCATE supported vendors list
- Add separate test workflows for SQLite, PostgreSQL, and MySQL
2ykwang
force-pushed
the
support-postgrelsql-docker-test
branch
from
c6caf58 to
3725694
Compare
2ykwang
changed the title
hramezani
reviewed
Aug 17, 2025
|
|
||
| class TruncateQuery: | ||
| SUPPORTED_VENDORS = ("postgresql", "mysql", "sqlite", "oracle", "microsoft") | ||
| SUPPORTED_VENDORS = ("postgresql", "mysql", "oracle", "microsoft") |
Member
There was a problem hiding this comment.
why did you remove sqlite here?
Member
Author
There was a problem hiding this comment.
SQLite doesn’t support the TRUNCATE query (docs).
I noticed this while running the SQLite tests.
From what I found, DELETE basically works as the replacement.
- Add database type to coverage upload names (SQLite/PostgreSQL/MySQL)
hramezani
approved these changes
Aug 17, 2025
Member
|
Thanks @2ykwang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #745