Skip to content

Conversation

@mostafaeftekharizadeh
Copy link
Contributor

  • Added support for CustomLogEntry data model to extend django-auditlog capabilities

  • Updated existing test cases to align with new model structure and data handling logic

  • Added new test cases to validate CustomLogEntry behavior, model registration, and signal handling

  • Ensured backward compatibility with existing LogEntry model where applicable

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 98.50746% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.92%. Comparing base (0e58a9d) to head (1889387).

Files with missing lines Patch % Lines
auditlog/context.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
+ Coverage   95.85%   95.92%   +0.06%     
==========================================
  Files          35       35              
  Lines        1207     1250      +43     
==========================================
+ Hits         1157     1199      +42     
- Misses         50       51       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mostafaeftekharizadeh
Copy link
Contributor Author

Hi @2ykwang , could you please take a look at this PR when you have a moment? Your feedback would be really helpful. Thanks in advance!

@2ykwang
Copy link
Member

2ykwang commented Oct 8, 2025

Thanks for the PR! @mostafaeftekharizadeh

I’ll review it within this week.
In the meantime, could you please check the failing tests on MySQL and PostgreSQL?
Also, it looks like we’ll need updates to the CHANGELOG and related documentation for these changes.

@mostafaeftekharizadeh mostafaeftekharizadeh force-pushed the logentry-custom-model branch 3 times, most recently from 36834c7 to f430afa Compare October 14, 2025 11:43
@mostafaeftekharizadeh mostafaeftekharizadeh force-pushed the logentry-custom-model branch 2 times, most recently from dd49156 to 0f26418 Compare October 22, 2025 08:38
- Added support for CustomLogEntry data model to extend django-auditlog capabilities

- Updated existing test cases to align with new model structure and data handling logic

- Added new test cases to validate CustomLogEntry behavior, model registration, and signal handling

- Ensured backward compatibility with existing LogEntry model where applicable
@mostafaeftekharizadeh mostafaeftekharizadeh force-pushed the logentry-custom-model branch 5 times, most recently from 20707f1 to af7eb1f Compare October 22, 2025 10:06
@hramezani
Copy link
Member

Lint is failing in CI for Python 3.10. @mostafaeftekharizadeh could you figure out what the problem is?

@2ykwang Please review the PR when you have time.

@mostafaeftekharizadeh
Copy link
Contributor Author

Lint is failing in CI for Python 3.10. @mostafaeftekharizadeh could you figure out what the problem is?

@2ykwang Please review the PR when you have time.

Linter issue resolved.

Copy link
Member

@2ykwang 2ykwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mostafaeftekharizadeh

do we need to run the full test suite for both LogEntry and CustomLogEntry?

I’m worried this might unnecessarily increase test runtime. maybe we could just add specific tests for the custom model instead?

Co-authored-by: Youngkwang Yang <[email protected]>
@mostafaeftekharizadeh
Copy link
Contributor Author

@mostafaeftekharizadeh

do we need to run the full test suite for both LogEntry and CustomLogEntry?

I’m worried this might unnecessarily increase test runtime. maybe we could just add specific tests for the custom model instead?

Given the large amount of changes, I suggest running the full test suite for CustomLogEntry at least once, for example, on the latest LTS version.

Copy link
Member

@2ykwang 2ykwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the large amount of changes, I suggest running the full test suite for CustomLogEntry at least once, for example, on the latest LTS version.

What if we just add one custom model test matrix instead? For example:

py312-customlogmodel-django52

@2ykwang
Copy link
Member

2ykwang commented Nov 11, 2025

@hramezani could you take a look as well?

@hramezani
Copy link
Member

Given the large amount of changes, I suggest running the full test suite for CustomLogEntry at least once, for example, on the latest LTS version.

What if we just add one custom model test matrix instead? For example:

py312-customlogmodel-django52

Agree, let's add only one custom model test to the matrix

@hramezani
Copy link
Member

Thanks @mostafaeftekharizadeh for continuing on this PR.
Please address the above comments when you have time.

@2ykwang 2ykwang added this to the 3.4.0 milestone Nov 11, 2025
@mostafaeftekharizadeh mostafaeftekharizadeh force-pushed the logentry-custom-model branch 3 times, most recently from b7432d7 to dc5983e Compare November 17, 2025 04:57
@mostafaeftekharizadeh
Copy link
Contributor Author

Thanks @mostafaeftekharizadeh for continuing on this PR. Please address the above comments when you have time.

Done.

Copy link
Member

@2ykwang 2ykwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. thanks for the contribution! @mostafaeftekharizadeh

@hramezani hramezani merged commit 7d13fd4 into jazzband:master Nov 19, 2025
15 checks passed
@hramezani
Copy link
Member

Thanks @mostafaeftekharizadeh for the PR and @2ykwang for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for CustomLogEntry Model Add AbstractLogEntry class to allow extension without creating additional table

3 participants