-
Notifications
You must be signed in to change notification settings - Fork 437
Add CustomLogEntry model support and update tests: #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 95.85% 95.92% +0.06%
==========================================
Files 35 35
Lines 1207 1250 +43
==========================================
+ Hits 1157 1199 +42
- Misses 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1c4b924 to
4d2b96e
Compare
|
Hi @2ykwang , could you please take a look at this PR when you have a moment? Your feedback would be really helpful. Thanks in advance! |
|
Thanks for the PR! @mostafaeftekharizadeh I’ll review it within this week. |
36834c7 to
f430afa
Compare
dd49156 to
0f26418
Compare
- Added support for CustomLogEntry data model to extend django-auditlog capabilities - Updated existing test cases to align with new model structure and data handling logic - Added new test cases to validate CustomLogEntry behavior, model registration, and signal handling - Ensured backward compatibility with existing LogEntry model where applicable
20707f1 to
af7eb1f
Compare
|
Lint is failing in CI for Python 3.10. @mostafaeftekharizadeh could you figure out what the problem is? @2ykwang Please review the PR when you have time. |
af7eb1f to
e1324f4
Compare
e1324f4 to
7e4ee64
Compare
Linter issue resolved. |
2ykwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to run the full test suite for both LogEntry and CustomLogEntry?
I’m worried this might unnecessarily increase test runtime. maybe we could just add specific tests for the custom model instead?
Co-authored-by: Youngkwang Yang <[email protected]>
Given the large amount of changes, I suggest running the full test suite for CustomLogEntry at least once, for example, on the latest LTS version. |
2ykwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the large amount of changes, I suggest running the full test suite for CustomLogEntry at least once, for example, on the latest LTS version.
What if we just add one custom model test matrix instead? For example:
py312-customlogmodel-django52|
@hramezani could you take a look as well? |
Agree, let's add only one custom model test to the matrix |
|
Thanks @mostafaeftekharizadeh for continuing on this PR. |
b7432d7 to
dc5983e
Compare
dc5983e to
1889387
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. thanks for the contribution! @mostafaeftekharizadeh
|
Thanks @mostafaeftekharizadeh for the PR and @2ykwang for the review |
Added support for CustomLogEntry data model to extend django-auditlog capabilities
Updated existing test cases to align with new model structure and data handling logic
Added new test cases to validate CustomLogEntry behavior, model registration, and signal handling
Ensured backward compatibility with existing LogEntry model where applicable