Fix interaction with procrastinate #401
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running procrastinate subcommands when configurations is installed gives the following error:
The monkey-patching in create_parser caused this in an interesting way:
Procrastinate uses the add_arguments hook to check the previously defined arguments like this:
in order to later filter them out like this:
This is a problem because the CONFIGURATION_ARGUMENT arg is added after procrastinate's
add_arguments
is called. Here's the call graph:This commit esesentially swaps the inner two actions so it looks like this:
It does this by temporarily overriding
add_arguments
with a no-op and then later restoring and calling it.This is a hack on top of two hacks, but I can't really see any other ways to make it work.