Fix error handling on duplicated APNS devices #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bielfrontera
force-pushed
the
fix-on-error-duplicated-apnsdevice
branch
from
c5918d0 to
305051b
Compare
manelclos
approved these changes
Sep 10, 2024
nossila
approved these changes
Sep 25, 2024
|
Thanks @bielfrontera. It looks like there is a merge conflict, once that is fixed we can get this merged. |
bielfrontera
force-pushed
the
fix-on-error-duplicated-apnsdevice
branch
from
305051b to
8a85833
Compare
Great! I've rebased and fixed the merge conflict. |
50-Course
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a duplicated registration ID on the APNSDevice model and we get an unregistered error after sending a message, it raises a
MultipleObjectsReturnedexception (get() returned more than one APNSDevice -- it returned ...!).In order to fix this, we can update all the records with that registration ID instead of using
objects.get.