Add type anotation to methods and functions #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50-Course
reviewed
Sep 21, 2025
Comment on lines
+6
to
+10
| from typing import Any | ||
| from push_notifications.fields import UNSIGNED_64BIT_INT_MAX_VALUE, hex_re | ||
| from push_notifications.models import APNSDevice, GCMDevice, WebPushDevice, WNSDevice | ||
| from push_notifications.settings import PUSH_NOTIFICATIONS_SETTINGS as SETTINGS | ||
| from django.db.models import QuerySet |
There was a problem hiding this comment.
@50-Course any update on this PR
There was a problem hiding this comment.
@miky-rola sorry its midnight out here, timezone-ish 😅 - so simply went to bed immediately, its is 4am right now. but finsihed reviewing.
50-Course
approved these changes
Sep 22, 2025
50-Course
added a commit
that referenced
this pull request
Sep 22, 2025
This reverts commit 4c47abc.
jamaalscarlett
pushed a commit
that referenced
this pull request
Sep 22, 2025
|
Hi @miky-rola, thanks for this PR however, this just broke compatibility support for ~3.9, as much as we would love to stick to the new typing system, we also have to support (presently) existing systems, can you please reupdate this PR, newly with support for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..anywith the rightAny