Skip to content

Conversation

@LomNtetha
Copy link

@LomNtetha LomNtetha commented Mar 21, 2024

Description

This is a new feature for wizard templates. It adds a new sign-in button to the wizard actions and includes authentication for users. The sign-in button will be displayed only when the user is not authenticated. Otherwise, it will display other buttons. This feature ensures that the sign-in button is hidden when the user is logged in, without interfering with the functionality of the templates

Motivation and Context

This feature helps to remove the cancel, back, and previous buttons that are shown on the sign-in page when the user is not authenticated.

How Has This Been Tested?

New tests have been created for this feature, and they pass successfully. The two test functions are named test_render_template_authenticated and test_render_template_not_authenticated.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@moggers87
Copy link
Collaborator

I'm not sure I understand the motivation for this change. If I understand what you've done right then an unauthenicated user would see "sign-in" rather than "next" on every step of a wizard, which would be a little confusing if there was more than one step IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants