Skip to content

Conversation

@AnonymousAccount4SE
Copy link

Renaming Suggestion of Method Names to Make Them More Descriptive


Description

We have developed a tool (NameSpotter) for identifying non-descriptive method names, and using this tool we find a non-descriptive method name in your repository:

/* Non-descriptive Method Name in orm/plugin/core/org.hibernate.eclipse.console/src/org/hibernate/eclipse/console/actions/RenameAction.java */
	public boolean renameConsoleConfiuration(ConsoleConfiguration config){
		ILaunchConfiguration launchConfiguration = null;;
		try {
			launchConfiguration = LaunchHelper.findHibernateLaunchConfig(config.getName());
		} catch (CoreException e) {
			HibernateConsolePlugin.getDefault().showError(null, HibernateConsoleMessages.RenameAction_error_title, e);
		}
		return launchConfiguration != null ? renameLaunchConfiguration(launchConfiguration) : false;
	}

We considered "renameConsoleConfiuration" as non-descriptive because it contains a typo (i.e., Confiuration should be Configuration).
We have corrected it and submitted a pull request.

Do you agree with the judgment?

  • If not, could you please leave your valuable opinion?

  • If you do agree, the relevant modification has been submitted as a PR, and thanks for your precious time to consider it.

Signed-off-by: AnonymousAccount4SE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant