Skip to content

Conversation

kaya70875
Copy link

No description provided.

@0xRaduan
Copy link

any chance this could get a review @jdepoix ?

@jdepoix
Copy link
Owner

jdepoix commented Sep 19, 2025

Hi @0xRaduan @kaya70875,
First of all, thank you for your contribution @kaya70875!
I only had a very brief look at this, but it does not seem to follow the approach that has been discussed in #514 (refactoring TrascriptListFetcher to be async and wrapping sync call with asyncio.run in YouTubeTranscriptApi). Refactoring TrascriptListFetcher instead of adding TranscriptListFetcherAsync, would also make the code much easier to review, as it seems to contain a lot of copy-pasted code from TranscriptListFetcher.
I will have a closer look at this if these changes get implemented! 👍

@kaya70875
Copy link
Author

kaya70875 commented Sep 24, 2025

@jdepoix Thanks for feedback. I guess I misunderstood, I thought we should not refactor anything and use existing modules to create YoutubeTranscriptAsyncApi class. That's why there is too much code duplication.

I'll refactor my PR accordingly based on your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants