Empty GCD drawing queue prior to sleep#86
Merged
jdtsmith merged 1 commit intoemacs-mac-30_1_expfrom Sep 13, 2025
Merged
Conversation
If GCD is enabled, drawing blocks in the queue during a sleep/wake cycle may have invalid contexts. Empty the queue prior to sleep to avoid this. * src/macappkit.m ([EmacsController applicationDidFinishLaunching:]): Add `willSleep' observer.
Owner
Author
|
For those who sleep/wake a lot and use Grand Central Dispatch (the default), please test this and report any problems. It takes ~a week for this bug to reproduce here, so I'll keep this open for a while. |
Owner
Author
|
This seems at least to do no harm. I did encounter another similar freeze-on-wake, but it may have been without this patch. Merging, and will keep monitoring. |
Owner
Author
|
Update: sleep seems to be related only tangentially here. It's possible this is a deadlock arising from calling sync from within a block already executing from the same queue on the main thread; see #113. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If GCD is enabled, drawing blocks in the queue during a sleep/wake cycle
may have invalid contexts. Empty the queue prior to sleep to avoid
this.
Add `willSleep' observer.
Hopefully fixes #78.