Improve Embeds, Major Refactor/Cleanup #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andre601
reviewed
Feb 1, 2025
src/main/java/nz/co/jammehcow/jenkinsdiscord/util/EmbedUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: solonovamax <[email protected]>
11 tasks
KocproZ
requested changes
May 20, 2025
| this.j.assertEqualDataBoundBeans(step, roundtrippedStep); | ||
| } catch (Exception e) { | ||
| fail(); | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Is there a reason for wrapping this exception in a RuntimeException?
| StringUtils.stripToNull(this.customUsername), | ||
| null, | ||
| null, | ||
| this.dynamicFieldContainer, |
There was a problem hiding this comment.
dynamicFieldContainer fields should also be expanded with env variables.
See lines 200, 202, 206, 210
| if (step.getCustomUsername() != null) { | ||
| wh.setCustomUsername(step.getCustomUsername()); | ||
| } | ||
| protected DiscordPipelineStepExecution(DiscordPipelineStep step, StepContext context) { |
| embedBuilder.addField(new EmbedField(true, "Branch", branch)); | ||
| } | ||
|
|
||
| String buildResult = Objects.requireNonNull(build.getResult()).toString().toLowerCase(Locale.ENGLISH); |
There was a problem hiding this comment.
Use the result field from DiscordPipelineStep, not Run.
|
|
||
| String username = EmbedUtil.withFallback(customUsername, "Jenkins"); | ||
| String avatar = EmbedUtil.withFallback(customAvatarUrl, "https://get.jenkins.io/art/jenkins-logo/1024x1024/headshot.png"); | ||
| embedBuilder.setAuthor(new EmbedAuthor(username, avatar, null)); |
There was a problem hiding this comment.
Username and avatar should also be set on the webhook message to match previous functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves embeds and a major refactor/cleanup of basically everything.
This improves embeds based off of the suggestions provided via #27
Here's a list of relevant issues
Here are the changes to the embed:
For the refactors/cleanup:
Testing done
Honestly I have no clue how to do testing with Jenkins plugins. Would love feedback for that if tests are needed, however since there were already basically no tests I felt it wasn't super needed.
Submitter checklist