Skip to content

Conversation

0blu
Copy link
Contributor

@0blu 0blu commented Sep 1, 2024

Fixes the compilation on VS14 / 2015.

@0blu
Copy link
Contributor Author

0blu commented Sep 1, 2024

There are also some warnings when converting from BOOL (aka int) to bool.
Which could be solved with != 0 check. (e.g. return _isatty(fd) != 0;)

Copy link
Owner

@jeremy-rifkin jeremy-rifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this! I wish it were easier for me to test older versions of compilers in CI to prevent regressions. I'll have to look into doing so later.

Copy link
Owner

@jeremy-rifkin jeremy-rifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to do this and working through the review comments! Looks good to me!

@jeremy-rifkin jeremy-rifkin changed the base branch from main to dev September 5, 2024 01:58
@jeremy-rifkin jeremy-rifkin merged commit 0d89be4 into jeremy-rifkin:dev Sep 5, 2024
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants