Skip to content

Avoid using dynamically allocated vector for punctuators_and_operators #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
Merged

Avoid using dynamically allocated vector for punctuators_and_operators #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e92cb53
Avoid using dynamically allocated vector for punctuators_and_operator…
codeinred Aug 23, 2025
89b1a2c
Update prune_symbol.cpp
jeremy-rifkin Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 61 additions & 16 deletions src/prune_symbol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,22 +60,67 @@ namespace detail {
}

// http://eel.is/c++draft/lex.operators#nt:operator-or-punctuator
const std::vector<string_view> punctuators_and_operators = []() {
std::vector<string_view> vec{
"{", "}", "[", "]", "(", ")",
"<:", ":>", "<%", "%>", ";", ":", "...",
"?", "::", ".", ".*", "->", "->*", "~",
"!", "+", "-", "*", "/", "%", "^", "&", "|",
"=", "+=", "-=", "*=", "/=", "%=", "^=", "&=", "|=",
"==", "!=", "<", ">", "<=", ">=", "<=>", "&&", "||",
"<<", ">>", "<<=", ">>=", "++", "--", ",",
// "and", "or", "xor", "not", "bitand", "bitor", "compl",
// "and_eq", "or_eq", "xor_eq", "not_eq",
"#", // extension for {lambda()#1}
};
std::sort(vec.begin(), vec.end(), [](string_view a, string_view b) { return a.size() > b.size(); });
return vec;
} ();
// These must be ordered by length, longest first.
const string_view punctuators_and_operators[] {
// 3 character operators
"->*",
"...",
"<=>",
"<<=",
">>=",
// 2 character operators
"<:",
":>",
"<%",
"%>",
"::",
".*",
"->",
"+=",
"-=",
"*=",
"/=",
"%=",
"^=",
"&=",
"|=",
"==",
"!=",
"<=",
">=",
"&&",
"||",
"<<",
">>",
"++",
"--",
// 1 character operators
"{",
"}",
"[",
"]",
"(",
")",
";",
":",
"?",
".",
"~",
"!",
"+",
"-",
"*",
"/",
"%",
"^",
"&",
"|",
"=",
"<",
">",
",",
"#", // extension for {lambda()#1}
};

const std::array<string_view, 2> anonymous_namespace_spellings = {"(anonymous namespace)", "`anonymous namespace'"};

Expand Down
Loading