feat(header): move symbol info from main header to chart panel#167
Open
jeziellopes wants to merge 1 commit intodevelopfrom
Open
feat(header): move symbol info from main header to chart panel#167jeziellopes wants to merge 1 commit intodevelopfrom
jeziellopes wants to merge 1 commit intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jeziellopes
force-pushed
the
feat/symbol-info-in-chart-header
branch
from
61865cb to
93f4dd4
Compare
jeziellopes
force-pushed
the
feat/symbol-info-in-chart-header
branch
from
93f4dd4 to
90415de
Compare
jeziellopes
force-pushed
the
feat/symbol-info-in-chart-header
branch
from
90415de to
5386e70
Compare
…trip - Remove TickerHeader from __root.tsx; main header shows Logo + 'Flow' on all routes with no route-conditional logic - Add TickerStatStrip — horizontal row of muted stat cards (symbol selector + live price + change %, then Open / High / Low / Vol cards) inspired by Binance Futures ticker strip - Chart panel title is now <TickerStatStrip />; timeframe tabs stay as Panel.Header extra on the right — one compact header row - Panel accepts title: ReactNode; string titles render as <h2> with existing uppercase style; ReactNode titles render as-is (backward compat) Closes #166 Signed-off-by: Jeziel Lopes <jeziellopes@gmail.com>
jeziellopes
force-pushed
the
feat/symbol-info-in-chart-header
branch
from
5386e70 to
04c272f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves symbol ticker info from the main app header into the chart panel header as a Binance-inspired compact stat strip. The main header is simplified to show only the logo + brand name.
Changes
New component:
TickerStatStriptext-[9px]) and compact values (text-[11px]),px-2 py-0.5paddingextraslot (right side)Updated:
Panel(title: ReactNode)titleprop widened fromstringtoReactNode<h2>with uppercase/tracking style (backward-compatible)TickerStatStrip)Updated:
__root.tsx<Logo /> Flow— no route-conditional logicTickerHeader,useRouterState,isSymbolRouteUpdated:
-trading-layout.tsxtitle={<TickerStatStrip />}Visual Result
BTCUSDT · 72,820 +0.70% | O 72,312 | H 73,434 | L 71,426 | Vol 17,367 | 5m 1h 4h 1d⚡ FlowonlyChecklist
pnpm typecheck— cleanpnpm test— 349 passedCloses #166