Fix reading manifest in F3D importer #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, importing failed with the manifest I had: b"\x07\x00\x00\x003-2-0-0\r\x00\x00\x00FusionDocType\x04\x00\x00\x00.\x00f\x003\x00d\x00\x0f\x00\x00\x00F\x00u\x00s\x00i\x00o\x00n\x00 \x00D\x00o\x00c\x00u\x00m\x00e\x00n\x00t\x00\x11\x00\x00\x00A\x00 \x00F\x00u\x00s\x00i\x00o\x00n\x00 \x00D\x00o\x00c\x00u\x00m\x00e\x00n\x00t\x00$\x00\x00\x00a\x00b\x00a\x007\x005\x00d\x000\x007\x00-\x00b\x004\x008\x00d\x00-\x004\x00e\x00c\x008\x00-\x009\x002\x005\x000\x00-\x005\x00a\x000\x008\x00d\x009\x008\x00b\x004\x003\x009\x008\x00$\x00\x00\x00d\x008\x000\x00e\x003\x00b\x009\x005\x00-\x000\x009\x00f\x00d\x00-\x004\x001\x00f\x00e\x00-\x008\x004\x006\x007\x00-\x00d\x009\x000\x009\x005\x00b\x001\x009\x004\x004\x000\x00f\x00\xd2\x04\x00\x00\x13\x00\x00\x004\x00\x00\x00@\x00\xac(\x07\x00\x00\x00\x0b\x00\x00\x00Application\x01\x00\x00\x00\x03\x00\x00\x00CAM\x04\x00\x00\x00\x08\x00\x00\x00ParaMesh\x08\x00\x00\x00\t\x00\x00\x00SimCommon5u\x00\x00\x0f\x00\x00\x00SimFEACSObjects\x02\x00\x00\x00\x10\x00\x00\x00SimFluidDynamics\x02\x00\x00\x00\x17\x00\x00\x00SimStructuralAttributes\x12'\x00\x00\x00\x00\x00\x00\x00$\x00\x00\x002\x00f\x00f\x006\x00c\x00c\x006\x00f\x00-\x00f\x006\x00d\x00e\x00-\x004\x00e\x000\x00a\x00-\x00a\x007\x00a\x004\x00-\x00f\x00c\x005\x005\x00f\x009\x001\x000\x005\x008\x00f\x009\x00\x01\x00\x00\x00\x0f\x00\x00\x00F\x00u\x00s\x00i\x00o\x00n\x00A\x00s\x00s\x00e\x00t\x00N\x00a\x00m\x00e\x00\x00\x00\x00\x00\x01" The length of the unknown array `a1` was incorrectly assumed to be 2 whereas it was 4 in my case. The length is now taken from the distance to the next known field `Application`. Signed-off-by: Gaël Écorchard <[email protected]>
Contributor
|
@jmplonka any chance you can review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, importing failed with the manifest I had.
The length of the unknown array
a1was incorrectly assumed to be 2 whereas it was 4 in my case.The length is now taken from the distance to the next known field
Application.There's commit bcbd2c2 that also deals with the manifest but the changes there after reading
cnt, so that the bug should also affect it.box_v4.zip is the Fusion 360 file I received from someone.