Add a lookup option to allow users to implement their own DNS resolution #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #314.
Users can provide a
lookupoption to replace Node.js's internal default synchronous DNS resolution, significantly improving performance in cases where DNS resolution might time out.The
dns.resolve()methods are asynchronous but behave slightly differently from the defaultdns.lookup(). For example,dns.resolve()does not follow the local hosts file. Considering these behavioral differences, an option is provided for users to pass in, rather than modifying it internally.Reference Information: #314 and Nodejs DNS docs