Skip to content

Fix group duplication issue during import by checking for existing group before creating a new one #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mailrucp wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix group duplication issue during import by checking for existing group before creating a new one #3916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions fileio/json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,30 @@ public function load( $group, $filename, $data ) {
if ( isset( $json['redirects'] ) ) {
foreach ( $json['redirects'] as $pos => $redirect ) {
unset( $redirect['id'] );


// Check if the group ID already exists in the group map
if ( ! isset( $group_map[ $redirect['group_id'] ] ) ) {
$new_group = Red_Group::create( 'Group', 1 );
$group_map[ $redirect['group_id'] ] = $new_group->get_id();
// Use the get method to check if the group exists in the database by its ID
$existing_group = Red_Group::get( $redirect['group_id'] );

if ( $existing_group ) {
// If the group exists, store its ID in the group map for later use
$group_map[ $redirect['group_id'] ] = $existing_group->get_id();
} else {
// If the group does not exist, create a new group
$new_group = Red_Group::create( 'Group', 1 );
$group_map[ $redirect['group_id'] ] = $new_group->get_id();
}
}

if ( $redirect['match_type'] === 'url' && isset( $redirect['action_data'] ) && ! is_array( $redirect['action_data'] ) ) {
$redirect['action_data'] = array( 'url' => $redirect['action_data'] );
}

$redirect['group_id'] = $group_map[ $redirect['group_id'] ];
Red_Item::create( $redirect );
$count++;

// Helps reduce memory usage
unset( $json['redirects'][ $pos ] );
$wpdb->queries = array();
Expand Down