Add support for PMMP 3.19.0#309
Conversation
|
this doesnt add support for 3.19 |
|
I've tested it, it adds support for 3.19.0 |
|
but don't use PureEntitiesX with this fix or use my fix of PureEntitiesX too |
| $pk2->username = $this->getDisplayName($player); | ||
| $pk2->position = $this->asVector3()->add(0, static::HEIGHT); | ||
| $pk2->item = ItemFactory::get(ItemIds::AIR); | ||
| $pk2->item = ItemStackWrapper::legacy(Item::get(Item::AIR)); |
There was a problem hiding this comment.
Here, changing ItemFactory and ItemIds to Item is an unrelated change. Please revert it. Also, remove the added import for pocketmine\item\Item
| $pk2->username = $this->getDisplayName($player); | ||
| $pk2->position = $this->asVector3()->add(0, static::HEIGHT); | ||
| $pk2->item = ItemStackWrapper::legacy(Item::get(Item::AIR)); | ||
| $pk2->item = ItemStackWrapper::legacy(Item::get(ItemIds::AIR)); |
There was a problem hiding this comment.
Also change Item::get back to ItemFactory::get
|
:) |
|
why nobody merges |
|
because nobody cares :( |
| name: Slapper | ||
| author: jojoe77777 | ||
| version: 1.7.0 | ||
| version: 1.7.1 |
There was a problem hiding this comment.
Since the previous version bump you made was never merged into master, I think there is no need for another one
| version: 1.7.1 | ||
| description: Slapper, the NPC plugin for PocketMine-MP | ||
| main: slapper\Main | ||
| api: 3.13.0 |
There was a problem hiding this comment.
You need to bump the minimum required API version to 3.14.0 since ItemStackWrapper::legacy was added there: pmmp/PocketMine-MP@3.13.1...3.14.0#diff-68d4439663f67995bb26425e333d43bbce3d952bbc1df6f26dcdc1173bad458cR41
Because jojoe77777 doesn't care |
6 participants
Fixed bugs in PMMP 3.19.0