Update for PM 3.14.0#11
Update for PM 3.14.0#11Xenophilicy wants to merge 5 commits intojojoe77777:masterfrom xenoservers:master
Conversation
Fixes lots of old, outdated API calls. Added support for using FormAPI virion rather than depending on the plugin. Fixed form images crashing issue.
|
This makes a bunch of formatting and doc changes that have nothing to do with the functionality. |
|
Is there a reason those PHPDoc comments and formatting changes should be reverted? |
|
because they
Keep your changes separate. |
|
So, do you just want all the PHPDoc comments removed or something? I can just add "Updated PHPDoc comments" to the PR description if that makes you happy. That way the PR will be accurate to your liking and it won't just be a "functionality" update. |
|
It adds a bunch of noise to the diff that doesn't contribute towards the intended purpose (updating to latest PM), as such it should be done separately. I wouldn't accept this PR if it were to PM unless the changes were separated. Not to mention the fact that the doc comments I can see are just useless auto generated garbage anyway. |
|
@dktapps Ready for re-review of changes. All the "auto generated garbage" and "formatting and doc changes" should be undone now lol 👍 |
2 participants
Fixes lots of old, outdated API calls. Added support for using FormAPI virion rather than depending on the plugin. Fixed form images crashing issue.