Add dark mode toggle with localStorage support ✅ #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Dec 29, 2024
Owner
There was a problem hiding this comment.
This is great, thank you @DanielCruz12!
The only issue is all the unrelated changes. Can you remove them from this proposal, so that it only contains the minimum necessary patch to add a dark mode toggle?
I also prefer for the site to be fully functional with JavaScript disabled, if by any chance a dark mode can be added without requiring JS. If not, I may still merge this once the unrelated changes are removed.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to toggle dark mode, with the preference stored in localStorage for persistence.