Add onion error when missing payment_metadata #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested to send `incorrect_or_unknown_payment_details` if the `payment_metadata` was not set properly in the `tlv_payload` after being added to the invoice.
joostjager
force-pushed
the
custom-invoice-data
branch
3 times, most recently
from
536a16d to
b664f60
Compare
joostjager
force-pushed
the
custom-invoice-data
branch
3 times, most recently
from
bf944a4 to
6eb5660
Compare
joostjager
force-pushed
the
custom-invoice-data
branch
from
6eb5660 to
42dc90b
Compare
joostjager
force-pushed
the
custom-invoice-data
branch
from
42dc90b to
2ab3a9f
Compare
joostjager
pushed a commit
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested to send
incorrect_or_unknown_payment_detailsif thepayment_metadatawas not set properly in thetlv_payloadafter being added to the invoice.As suggested in lightning#912 (review)