feat: Add complex number support to math.mod function #3566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for complex numbers in the
math.modfunction using Gaussian integer division semantics.Problem Solved
Previously,
math.modwould throw a TypeError when given complex number inputs. This prevented users from performing modular arithmetic operations with complex numbers.Implementation
Complex, Complexsignature to the mod functionw/zfor complex inputswandzr = w - z*qwherenorm(r) < norm(z)Mathematical Properties
wandz≠0, findsqandrsuch thatw = z*q + rnorm(r) < norm(z)wherenorm(a+bi) = a² + b²Examples