Skip to content

Conversation

@Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Aug 11, 2025

Refactors the report viewer to be package based.

@Kr0nox Kr0nox changed the title Refactor erport viewer to work in packages Refactor report viewer to work in packages Aug 11, 2025
@Kr0nox Kr0nox marked this pull request as ready for review August 13, 2025 08:20
@Kr0nox Kr0nox requested review from a team August 13, 2025 08:20
@Kr0nox Kr0nox added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Aug 13, 2025
@Kr0nox Kr0nox mentioned this pull request Aug 14, 2025
@robinmaisch
Copy link
Member

robinmaisch commented Aug 21, 2025

I came across missing (dashed) edges in the cluster view – I'm not sure that I have seen them before. Could that have to do with this PR or is that more likely a pre-existing problem?
(showing only a snippet that does not give away the submission names)
image

@Kr0nox
Copy link
Member Author

Kr0nox commented Aug 22, 2025

I came across missing (dashed) edges in the cluster view

Sorry, I dont see which edge is missing. could you quickly elaborate or highlight it in the screenshot?

Do you mean just the existence of the dotted lines?
Yes, they were always there. If the comparison for that edge is not included in the report (due to not being in the top X comparisons), we do not have similarities for the edge

@robinmaisch
Copy link
Member

Do you mean just the existence of the dotted lines?

Yes, thank you, now I get it.
In that case, it looks good to me. I was not able to find any issues related to this PR.
@jplag/maintainer @jplag/devteam Any objections?

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

@Kr0nox Kr0nox merged commit 7c6ab1f into develop Aug 28, 2025
63 checks passed
@Kr0nox Kr0nox deleted the report-viewer/sub-modules branch August 28, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants