Skip to content

Conversation

@AQIB-NAWAB
Copy link
Contributor

What kind of change does this PR introduce?
bugfix

Issue Number:

Screenshots/videos:
Screencast from 2025-04-12 16-23-54.webm

Summary
In setting it is mentioned that foundation name should be in this convention foundation: <FOUNDATION_NAME> but it was written as foundation : JSON Schema. That's is the reasons it is rending invalid link and not showing the badge.

Does this PR introduce a breaking change?
Nope, I test it an working fine.

@AQIB-NAWAB
Copy link
Contributor Author

@benjagm Please review the PR.
Thanks

@AQIB-NAWAB
Copy link
Contributor Author

AQIB-NAWAB commented Apr 25, 2025

Hi @benjagm , please review PR

Copy link
Contributor

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks Aqib!!

@benjagm benjagm merged commit 391c5a3 into json-schema-org:main May 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Badge markdown code is not correct and show invalid link

2 participants