Updated Readme.MD to fix a specific issue #89
Conversation
This readme change is a quickfix for people that might run into this nasty little bug jsumners#84
|
I have no idea why the tests are failing. I just changed some lines in the readme.md nothing else. |
|
Me too, no idea why the build fails, but in my humble opinion the Usage alinea is supposed to be short. I would leave that as it was, e.g. with only url,baseDN,username,password. The next chapter (Constructor), where the |
|
|
||
| ```js | ||
| var ActiveDirectory = require('activedirectory2'); | ||
| var config = { url: 'ldap://dc.domain.com', |
There was a problem hiding this comment.
With this change, I'd go ahead and change the whole block to look like:
var config = {
url: 'foo',
user: [
// comment
'dn'
]
}The current reduced format become illegible with the inlined comments.
Are you sure your branch it up to date with |
|
The tests are not passing due to ldapjs/node-ldapjs#686 |
3 participants
This readme change is a quickfix for people that might run into this nasty little bug #84