Skip to content

feat(transloco): transpile function arguments in FunctionalTranspiler (#829) #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(transloco): transpile function arguments in FunctionalTranspiler (#829) #832

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec8ff1c
feat(transloco): transpile function arguments in FunctionalTranspiler…
Jan 15, 2025
e499424
Merge branch 'jsverse:master' into transloco-functionaltranspiler
f-aubert Aug 11, 2025
d1439bb
feat(transloco): transpile function arguments in FunctionalTranspiler…
Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions libs/transloco/src/lib/tests/transpiler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,22 @@ describe('TranslocoTranspiler', () => {
);
});

it('should transpile the function params', () => {
const spy = spyOn(transpilerFunctions['upperCase'], 'transpile');
transpiler.transpile(getTranspilerParams('[[ upperCase(lowercase) ]]'));
expect(spy).toHaveBeenCalledWith('lowercase');
spy.calls.reset();
transpiler.transpile(
getTranspilerParams(
'[[ upperCase(lowercase, {{person}}, {{ anotherParson.name }}) ]]',
{
params: { person: 'Shahar', anotherParson: { name: 'Netanel' } },
},
),
);
expect(spy as any).toHaveBeenCalledWith('lowercase', 'Shahar', 'Netanel');
});

it('should work with interpolation params', () => {
const parsed = transpiler.transpile(
getTranspilerParams('[[ testParams(and {{anotherParson}}) ]]', {
Expand Down
6 changes: 5 additions & 1 deletion libs/transloco/src/lib/transloco.transpiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@ export class FunctionalTranspiler
const func: TranslocoTranspilerFunction =
this.injector.get(functionName);

return func.transpile(...getFunctionArgs(args));
return func.transpile(
...getFunctionArgs(args).map((arg) =>
this.transpile({ value: arg, ...rest }),
),
Copy link
Collaborator

@shaharkazaz shaharkazaz Aug 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question here do we want to support nested function transpilations? I'm not sure that would actually work.
Add a test case, if that works, cool. otherwise let's skip directly to the parent transpiler

const transpiledArgs = super.transpile({value: getFunctionArgs(args), ...rest});
return func.transpile(...transpiledArgs);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. As far as I can tell, this PR doesn't implements nesting function because getFunctionArgs use a simple pattern to separate the args, namely on comma. A regexp engine with support of nesting would be needed. I sure can look into that, but I could also live with this limitation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it simple

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the changes and test the pkg-pr-new release

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure what do you want me to do / change? I think the original code with the map call should do it... Thks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call the super like in the code I suggested

);
} catch (e: unknown) {
let message = `There is an error in: '${value}'.
Check that the you used the right syntax in your translation and that the implementation of ${functionName} is correct.`;
Expand Down
Loading