[Bridges] make attribute_value_type(::ListOfNonstandardBridges) less strict #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
COPT as well. So I don't think this is negotiable anymore: |
odow
force-pushed
the
od/listofnonstandardbridges
branch
from
b87e6fa to
f2b53e2
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2677
There are actually multiple existing implementations in the wild that I broke with the "bug fix" #2665
In addition to SCS and ECOS, there are:
https://github.com/jump-dev/SeDuMi.jl/blob/b69a1a664060216fabf0f101a8c21a3cf2df49f7/src/MOI_wrapper.jl#L69-L71
https://github.com/jump-dev/PolyJuMP.jl/blob/b28143bb2f68ff31b3c34d129ff2f403eb1752b4/src/model.jl#L109-L116
Perhaps we should just relax the type check.