Remove ConsoleLauncher configuration in Ant starter (#98)#114
Open
seachicken wants to merge 4 commits intojunit-team:mainfrom
Open
Remove ConsoleLauncher configuration in Ant starter (#98)#114seachicken wants to merge 4 commits intojunit-team:mainfrom
seachicken wants to merge 4 commits intojunit-team:mainfrom
Conversation
sbrannen
changed the title
sbrannen
previously requested changes
Oct 2, 2019
sbrannen
dismissed
their stale review
Let's push the use of Ivy to a separate issue
marcphilipp
approved these changes
Oct 4, 2019
Member
|
With two approvals and since I think his requested changes have been resolved, I think we can overrule @sbrannen this once. |
Member
|
Team decision: Keep using plain Ant |
Member
|
Actually, we missed the main point about moving away from using the |
Member
|
@sormuras will take it from here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #98
Fixes #115
I hereby agree to the terms of the JUnit Contributor License Agreement.