Modularize example program in junit-source-launcher#754
Closed
Modularize example program in junit-source-launcher#754
junit-source-launcher#754Conversation
Get rid of `--add-modules org.junit.start` but introduce more structural configuration, like a `module-info.java` file and an `example` package, and also an explicit class declaration - as compact source file cannot reside in a named package.
mpkorstanje
reviewed
Mar 19, 2026
| * https://www.eclipse.org/legal/epl-v20.html | ||
| */ | ||
|
|
||
| package example; |
Contributor
There was a problem hiding this comment.
While a bit more verbose using com.example.project would make this consistent with the other examples and provide just a bit more conventional context to make the package references elsewhere in the code instantly legible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change gets rid of
--add-modules org.junit.startcommand-line argument by introducing more structural configuration, like amodule-info.javafile and anexamplepackage, and also an explicit class declaration - as compact source file cannot reside in a named package.I hereby agree to the terms of the JUnit Contributor License Agreement.