Skip to content

Disable LexicographicalAnnotationAttributeListing #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

Disable LexicographicalAnnotationAttributeListing #5043

merged 1 commit into from
Oct 13, 2025

Conversation

@Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented Oct 9, 2025 •
edited
Loading

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@Pankraz76 Pankraz76 force-pushed the LexicographicalAnnotationListing--extend-errorprone branch from d106e13 to f68b088 Compare October 9, 2025 09:18
Pankraz76
Pankraz76 commented Oct 9, 2025
View reviewed changes
Copy link
Contributor Author

@Pankraz76 Pankraz76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting feedback and enabler:

This was referenced Oct 9, 2025
Open
Closed
Merged
@Pankraz76 Pankraz76 changed the title Add error-prone.picnic.tech featuring Lexicographical & StaticImport Add LexicographicalAnnotationAttributeListing Oct 12, 2025
@Pankraz76 Pankraz76 force-pushed the LexicographicalAnnotationListing--extend-errorprone branch from f68b088 to afcad28 Compare October 12, 2025 15:16
marcphilipp
marcphilipp requested changes Oct 13, 2025
View reviewed changes
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this rules does more harm than good. Could you please disable it explicitly (after rebasing on main) with a comment?

...launcher/src/main/java/org/junit/platform/launcher/jfr/FlightRecordingDiscoveryListener.java Outdated
}

@Category({ "JUnit", "Discovery" })
@Category({ "Discovery", "JUnit" })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is important here.

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Oct 13, 2025 •
edited
Loading

Thanks, yes of course, its always good to mark rejected stuff for the future.

@Pankraz76 Pankraz76 changed the title Add LexicographicalAnnotationAttributeListing Disable LexicographicalAnnotationAttributeListing Oct 13, 2025
@Pankraz76 Pankraz76 force-pushed the LexicographicalAnnotationListing--extend-errorprone branch from afcad28 to e473a09 Compare October 13, 2025 09:30
@Pankraz76 Pankraz76 requested a review from marcphilipp October 13, 2025 09:33
@Pankraz76 Pankraz76 marked this pull request as ready for review October 13, 2025 09:33
@marcphilipp marcphilipp merged commit 553458e into junit-team:main Oct 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @marcphilipp