-
Notifications
You must be signed in to change notification settings - Fork 8
Allow YRoom to be restarted and allow multi-room kernels
#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
36ee5de
remove rooms when they start stopping, not after
dlqqq 45e290b
automatically stop empty rooms in background task every 5s
dlqqq 0b4e494
bump to 10 second interval
dlqqq e7bf15b
only delete notebook rooms once kernel idle/dead
dlqqq 8f2180a
fix #111, implement update_session()
dlqqq 9c3b680
update kernel client to always use latest rooms from YRoomManager
dlqqq 50b7cd8
fix room cleanup for non-notebooks
dlqqq 7da899c
ensure returned rooms are kept alive for 10 seconds
dlqqq 1d15cde
update docstrings
dlqqq ad34d9e
refactor FileAPI, allow it to be restarted
dlqqq c967836
allow rooms to be restarted, unify stop() methods
dlqqq df80078
implement contents lock to prevent overlapping reads/writes
dlqqq 734a109
update YRoomManager to use new stop() API
dlqqq 8ffae7b
stop inactive rooms instead of deleting
dlqqq 37b8df0
fix extension stopping
dlqqq 70aceb9
restart inactive rooms instead of deleting
dlqqq 77e4852
revert changes to kernel client
dlqqq aff427f
fix empty notebooks after room restart
dlqqq a3dac7a
add observe_jupyter_ydoc() method for consumers
dlqqq ef31982
fix typos and missing type annotations (thanks @JGuinegagne)
dlqqq a7c90a5
disable _watch_rooms() task
dlqqq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.