Skip to content

Conversation

@Zsailer
Copy link
Collaborator

@Zsailer Zsailer commented Oct 24, 2025

Summary

Removes info-level logging for sync protocol messages (SS1, SS2, SyncUpdate) that flood the server logs during normal collaboration without providing actionable information.

Changes

  • Removed 8 log.info() calls that logged:
    • "Received SS1/SS2/SyncUpdate from client"
    • "Handled SS1/SS2/SyncUpdate from client"
    • "Sent SS2 reply to client"
    • "Sent SS1 message to client"
    • "Broadcasting SyncUpdate to all N synced clients"
    • "Broadcast of SyncUpdate complete for room"

Why

These messages occur on every keystroke and client sync during active collaboration, making logs difficult to read and obscuring important information. The sync protocol functions correctly without this logging, and error-level logging is preserved for debugging actual issues.

Impact

  • Significantly reduces log noise during active collaboration
  • Makes logs easier to read and search
  • Preserves all error and warning logging for debugging

Diff stats: 1 file changed, 1 insertion(+), 19 deletions(-)

Remove info-level logs for SS1, SS2, and SyncUpdate messages that flood
the logs without providing actionable information. These messages occur
frequently during normal collaboration and make it difficult to find
relevant log entries.

Kept error logging for debugging issues.
@Zsailer Zsailer requested a review from dlqqq October 24, 2025 05:16
@Zsailer Zsailer added the enhancement New feature or request label Oct 24, 2025
@Zsailer Zsailer merged commit 68d6c6b into jupyter-ai-contrib:main Oct 24, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants