Skip to content

Add missing type argument in delete_session #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zsailer merged 2 commits into from
May 14, 2025
Merged

Add missing type argument in delete_session #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4391dc1
Add missing type arguemnt in delete_session
Zsailer May 14, 2025
b6df4e4
Fix session deletion
Zsailer May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jupyter_rtc_core/kernels/websocket_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async def connect(self):
self.kernel_manager.broadcast_state()
self.log.info("Kernel websocket is now listening to kernel.")

async def disconnect(self):
def disconnect(self):
self.kernel_manager.main_client.remove_listener(self.handle_outgoing_message)

def handle_incoming_message(self, incoming_msg):
Expand Down
6 changes: 3 additions & 3 deletions jupyter_rtc_core/session_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ async def delete_session(self, session_id):
Deletes the session and disconnects the yroom from the kernel client.
"""
session = await self.get_session(session_id=session_id)
kernel_id, path = session["kernel_id"], session["path"]
yroom = self.get_yroom(path)
kernel_id, path, type = session["kernel"]["id"], session["path"], session["type"]
yroom = self.get_yroom(path, type)
kernel_client = self.get_kernel_client(kernel_id)
kernel_client.remove_yroom(yroom)
await kernel_client.remove_yroom(yroom)
await super().delete_session(session_id)
Loading