🐶 Add husky configuration #622
Conversation
|
✅ Deploy Preview for myst-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This seems to only be the case for the So, if you want, we can do prefix detection and run different commands for files coming from those directories. |
| "dependencies": {} | ||
| "lint-staged": { | ||
| "*.ts": "eslint --config ./.eslintrc.cjs --fix", | ||
| "*.{js,jsx,ts,tsx,md,html,css,json}": "prettier --write" |
There was a problem hiding this comment.
How does this align with the separate turborepo powered linting (which uses the eslint config from each respective package dir) that we have in place in scripts already? can the lint-staged call the respective npm scripts above? (just wanting to avoid two different sets of linting config)
Also will opening the pattern here beyond ts, tsx, md especially to include js, css mean that we are running prettier on the contents of dist/ and other build output folders?
There was a problem hiding this comment.
This is the same question I ask above, although I'm not sure if my meaning came through as clearly as it does here.
There was a problem hiding this comment.
The lint-staged package lets us only lint files that were touched during the commit.
I am not sure how to use the existing scripts, since afaik they don't take file arguments.
3 participants
This adds the (optional) ability to run a pre-commit hook to lint changes.
I find it quite helpful, in that it prevents me from having to go back and run eslint or prettier on my commits. We've had it for a while on the mystmd repo without complaints.