Skip to content

Conversation

@rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jul 22, 2025

This disables storybook for now by (1) removing it from the npm workspace and (2) moving the github workflow out of the right place.

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2025

🦋 Changeset detected

Latest commit: 0dea4da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@myst-theme/diagrams Patch
@myst-theme/frontmatter Patch
@myst-theme/icons Patch
@myst-theme/jupyter Patch
@myst-theme/landing-pages Patch
myst-demo Patch
myst-to-react Patch
@myst-theme/providers Patch
@myst-theme/site Patch
@myst-theme/article Patch
@myst-theme/book Patch
@myst-theme/styles Patch
@myst-theme/common Patch
@myst-theme/search Patch
@myst-theme/search-minisearch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 22, 2025

Deploy Preview for myst-theme ready!

Name Link
🔨 Latest commit 0dea4da
🔍 Latest deploy log https://app.netlify.com/projects/myst-theme/deploys/687f30a3efc55300084a5636
😎 Deploy Preview https://deploy-preview-634--myst-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rowanc1
Copy link
Member Author

rowanc1 commented Jul 22, 2025

Now that we have the myst-theme docs, I think storybook might be a bunch less useful, and perhaps we just simplify and remove it rather than keeping it alive?

I can confirm that the preview both works and is on React 19.1.0.

image

@stevejpurves
Copy link
Collaborator

IIRC jupyter deps might be loading react 18? Did you test case include any jupyter outputs? Jupyter-book/example-outputs might be helpful for testing

@stevejpurves
Copy link
Collaborator

would love to see React 19 come in but did anyone test with jupyter outputs in the mix here? and with in page execution? or is that still a todo?

@stefanv
Copy link
Collaborator

stefanv commented Nov 21, 2025

Are these test procedures / requirements outlined in a doc somewhere? It would be useful for future upgrades to have a checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants