🧜♀️ Upgrade mermaid to ^11 #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c987aa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for myst-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
agoose77
commented
Nov 12, 2025
stefanv
approved these changes
Nov 14, 2025
stefanv
reviewed
Nov 14, 2025
stefanv
reviewed
Nov 14, 2025
agoose77
commented
Nov 18, 2025
packages/diagrams/src/index.tsx
Outdated
| import classNames from 'classnames'; | ||
| import type { Mermaid } from 'mermaid'; | ||
|
|
||
| // Follow previous flow of importing mermaid dynamically. |
Collaborator
Author
There was a problem hiding this comment.
Ah, I meant to leave that in! I'm sure someone will still find this thread if needs be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In re-building
jupyterlab-myst, I ran into problems bundlingmermaidwith webpack because it pulls incytoscapewhich didn't bundle properly. I could dig into why that is, but it's a lot easier to just update everything (which fixed it!)@rowanc1 why is the mermaid import async here -- is this for explicit code splitting? Otherwise, can I hoist the import to the module level?