-
Notifications
You must be signed in to change notification settings - Fork 34
publish through GH releases #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
❌ Deploy Preview for myst-theme failed. Why did it fail? →
|
641f69b to
309177f
Compare
|
Thanks for this PR! I tend to prefer release-driven workflows in contexts like this. Have you thought about using a release to trigger the CI? I think this would simplify various parts of the workflow. |
|
As it is now, pushing a tag on github will trigger a release named after the tag |
|
Hi
one of the avenues I did give some thought to was the ability for another, more immediate rationale, was to make it easier for forked themes to produce their own releases; that's the workflow I am currently using to run on our own tweaked theme |
|
Hi @parmentelat, Thanks for the PR and it's great to have the longer thread linked for context! I had some questions/comments:
|
this is a follow-up on jupyter-book/mystmd#2317
in this first step, we add a GH workflow that publishes both book and article themes as GH releases attached to the current repo
this clearly is only a first step, but I would argue it should be merged right away
in particular this means a regular fork can use the same mechanism to publish its custom version by just setting a tag
see the issue for a status of the overall migration path