Handle exceptions in the load_session
#1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Jun 25, 2024
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
LGTM - thank you @weekenthralling.
lresende
approved these changes
Oct 17, 2024
weekenthralling
force-pushed
the
main
branch
from
3f14615 to
c3d924b
Compare
Contributor
Author
|
Rebased onto latest main to resolve CI issue. |
Member
|
@weekenthralling I believe the link that is failing the build has moved to Do you want to update here or in a new pr? |
Contributor
Author
I modified it in the new PR #1414 |
weekenthralling
force-pushed
the
main
branch
from
c3d924b to
3eba542
Compare
Member
|
As #1414 is merged, please rebase this one. |
Contributor
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refreshing the kernel, there might be other exceptions causing the refresh to fail. Perhaps catching exceptions would be more elegant.
For example:
When querying a non-existent kernel, the
load_sessionmethod from thewebhookreturns a404error. If this is not handled, the final API response is a500error, whereas the expected response is a404.