-
Notifications
You must be signed in to change notification settings - Fork 24
Adds support for the sketch
capability to the CadDocument
class
#805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Preview PR at appsharing.space |
Preview PR at appsharing.space |
Integration tests report: appsharing.space |
Integration tests report: appsharing.space |
Please lint the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @asmith26, nice work again
from .interfaces.fillet import IFillet # noqa | ||
from .interfaces.any import IAny # noqa | ||
|
||
from .interfaces.sketch import ISketchObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to take a look at pre-commit failure for this or just add # noqa
at the end of the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your help, following the other imports I've added # noqa
in 0403be4
geometry: List[ | ||
Union[geomCircle.IGeomCircle, geomLineSegment.IGeomLineSegment] | ||
] = [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have point, line and circle in sketch tool but i don't see point as option here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good spot. I couldn't find a geomPoint.py
. I'm not sure exactly how this works, but possibly geomLinSegment.py
and geomCircle.py
are generated from the schemas at github.com/jupytercad/JupyterCAD/tree/main/packages/schema/src/schema
, in particular it appears geomPoint.json
is missing.
I've noticed an issue with drawing Points which might be related (see #806) - I think I might have a fix for this, so happy to have try this before merging this PR (if helpful).
All thoughts very welcome. Thanks!
In case helpful here is my command:
sketch.mp4