-
Notifications
You must be signed in to change notification settings - Fork 25
Make non-running pods panels consistent and style them intuitively #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make non-running pods panels consistent and style them intuitively #164
Conversation
1c85e1a to
7d2075c
Compare
12f898f to
3e36c10
Compare
jnywong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm with this one I usually encounter a problem where the colour for another series "overlays" the time series for another, e.g. in the screenshot, the orange line for unknown should be zero over all time, but "overlays" the pending and failed series.
I see that you went with the time series and not bar chart panel to visualise. I wonder if we can overcome the "overlaying" by using a stacked barchart with mode normal?
|
Hmmm this is very confusing - why does it show up as orange peaks when not stacking? Shouldnt the orange stay at zero!? Separately, in your screenshot, i see failed as green - but this PR meant to make it red. Is thr screenshot from using this PRs panel? If so, there is a bug in it as i meant to change those colors! Edit: it looks like you hover a peak of 4 on the yaxis - 2 failed + 2 pending, but showing up as orange unknown. This indicates a stacked time series - so, the old version of this panel right? |
|
Yeah let's keep it non-stacked in this case. So I think this PR is good to go! Thanks for making these small UX enhancements @consideRatio |
|
Thank you @jnywong!! |



Before in JupyterHub dashboard:

Before in Cluster dashboard:

After in either:
