Skip to content

Set file ID on document state #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set file ID on document state #217

wants to merge 1 commit into from

Conversation

davidbrochart
Copy link
Collaborator

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/fileId

@davidbrochart davidbrochart mentioned this pull request Nov 28, 2023
Closed
@ellisonbg
Copy link

@dlqqq @Zsailer for review.

@Zsailer Zsailer added the enhancement New feature or request label Mar 6, 2024
@Zsailer
Copy link
Member

Zsailer commented Mar 6, 2024

Closing and re-opening to kick CI.

@Zsailer Zsailer closed this Mar 6, 2024
@Zsailer Zsailer reopened this Mar 6, 2024
@Zsailer
Copy link
Member

Zsailer commented Mar 6, 2024

This seems reasonable to me.

@davidbrochart
Copy link
Collaborator Author

I might reconsider this with the current work on the suggestion system.

@davidbrochart davidbrochart marked this pull request as draft March 7, 2024 14:02
@davidbrochart davidbrochart mentioned this pull request May 13, 2024
Merged
@davidbrochart davidbrochart marked this pull request as ready for review May 15, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zsailer Zsailer Zsailer approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

PR triage (experimental)
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidbrochart @ellisonbg @Zsailer