Skip to content

Conversation

@xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 2, 2025

Summary

Add publishing-bot rules for the release-0.29 branch. The diff is larger because this is the first time we use automation for managing this file and it uses a different indentation (we might fix that for the next time in our publishing-bot fork).

Command used (ran in the publishing-bot repo):

_output/update-rules -branch release-0.29 -go 1.24.9 -rules ../kcp/staging/publishing/rules.yaml -o /tmp/rules.yaml

What Type of PR Is This?

/kind cleanup

Release Notes

NONE

/assign @xrstf @mjudeikis

@kcp-ci-bot kcp-ci-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 2, 2025
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2025
@xrstf
Copy link
Contributor

xrstf commented Dec 2, 2025

/approve
/lgtm

I hate this. Half the file is formatted differently than the other, and the reason being "a tool did it". Then t hat tool is stupid.

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9354ef94629eb7041d507b165ddc28df5cc36337

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025
@kcp-ci-bot kcp-ci-bot merged commit 1736b49 into kcp-dev:main Dec 2, 2025
14 checks passed
@xmudrii xmudrii deleted the update-pb-rules branch December 2, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants