Update LogicalCluster example nits #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
do-not-merge/needs-kind
Contributor
|
/kind cleanup |
kcp-ci-bot
added
kind/cleanup
xrstf
reviewed
Dec 5, 2025
| cfgRoot.Host = strings.Split(cfgRoot.Host, "/clusters/")[0] | ||
|
|
||
| // Assume that our restConfig we use for this example can access all the workspaces: | ||
| // IMPORTANT: This should be shard-aware client, meaning it should go via front-proxy to be able to resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
Post review updates. Example got merged but some reviews came after.
Related Issue(s)
Fixes #
Release Notes