Merged
Conversation
…Lower/testHarm) - Add testUpper, testLower, testHarm params to gsDesign(), gsSurv(), gsSurvCalendar() - gsApplyTestBounds recomputes bounds with modified spending, preserving exact alpha - gsModifySpend flattens cumulative spending at inactive analyses - gsBoundSummary and print.gsDesign mask inactive bounds as NA - Relax gsBound/gsBound1 to allow 0 final spend (C code returns +/-EXTREMEZ) - Add SelectiveBoundTesting vignette with Type I error preservation examples - 114 unit tests for selective bounds; full suite 2573 pass, 0 fail - R CMD check: 0 errors, 0 warnings, 1 note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issue on not using every bound at every analysis.