feat: add environment variables for leader election timing configuration #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thank you for working on this. The PR looks good, but maybe we could also add some additional validation for these values? For instance, we should ensure that |
nader-ziada
force-pushed
the
leader-election-env-vars
branch
2 times, most recently
from
d32e493 to
88595fc
Compare
Add support for configuring leader election timing parameters through environment variables. Changes: - Add environment variable parsing in operator/main.go for: - KEDA_HTTP_OPERATOR_LEADER_ELECTION_LEASE_DURATION - KEDA_HTTP_OPERATOR_LEADER_ELECTION_RENEW_DEADLINE - KEDA_HTTP_OPERATOR_LEADER_ELECTION_RETRY_PERIOD - Pass parsed durations to ctrl.NewManager Options - Add test in operator/main_test.go covering parsing, defaults and error handling - Add configuration docs All three environment variables are optional. When not set, controller-runtime uses Kubernetes defaults (LeaseDuration: 15s, RenewDeadline: 10s, RetryPeriod: 2s). This allows operators to adjust leader election timing for different cluster configurations and network conditions without requiring code changes. Fixes: kedacore#1331 Signed-off-by: Nader Ziada <[email protected]>
Signed-off-by: Nader Ziada <[email protected]>
Signed-off-by: Nader Ziada <[email protected]>
nader-ziada
force-pushed
the
leader-election-env-vars
branch
from
88595fc to
a227029
Compare
thanks for the review @Fedosin, added the validation checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for configuring leader election timing parameters through environment variables.
Changes:
All three environment variables are optional. When not set, controller-runtime uses Kubernetes defaults (LeaseDuration: 15s, RenewDeadline: 10s, RetryPeriod: 2s). This allows operators to adjust leader election timing for different cluster configurations and network conditions without requiring code changes.
Fixes: #1331
Checklist
README.mddocs/directory