fix: open external LinkedIn link in new tab on author page#327
Open
agarwalpranav0711 wants to merge 1 commit intokeploy:mainfrom
Open
fix: open external LinkedIn link in new tab on author page#327agarwalpranav0711 wants to merge 1 commit intokeploy:mainfrom
agarwalpranav0711 wants to merge 1 commit intokeploy:mainfrom
Conversation
1 task
Contributor
|
Hi @agarwalpranav0711 The change fixes a very minor UI issue. Since the scope of this PR is quite small, we’d recommend exploring a slightly broader improvement or addressing a larger issue and including this fix as part of that update. Looking forward to seeing more from you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: External LinkedIn link opens in same tab
Problem
On the author details page, the external LinkedIn link was opening in the same browser tab.
This redirected users away from the blog website.
Root Cause
The
<Link>component was being used for an external URL without specifying:target="_blank"rel="noopener noreferrer"Solution
Replaced the Next.js
<Link>component with a standard<a>tag and added:target="_blank"rel="noopener noreferrer"This ensures:
Files Modified
components/author-description.jsxFixes: keploy/keploy#3796