Skip to content

fix: add hover effect for resources link in navbar#329

Open
vasu-CE wants to merge 2 commits intokeploy:mainfrom
vasu-CE:fix/header_hover
Open

fix: add hover effect for resources link in navbar#329
vasu-CE wants to merge 2 commits intokeploy:mainfrom
vasu-CE:fix/header_hover

Conversation

@vasu-CE
Copy link

@vasu-CE vasu-CE commented Feb 23, 2026

Related Tickets & Documents

Fixes keploy/keploy#3744

Description

Previously, the "Resources" menu item did not display the underline hover effect, while "Technology" and "Community" worked correctly. This caused inconsistent UI behavior across the navigation bar.

The fix ensures that the "Resources" item now follows the same hover styling logic, maintaining visual consistency across all navbar items.

Changes

Added missing hover underline styling to the "Resources" navbar item

Type of Change

  • Chore (maintenance, refactoring, tooling updates)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (change that adds functionality)
  • Breaking Change (may require updates in existing code)
  • UI improvement (visual or design changes)
  • Performance improvement (optimization or efficiency enhancements)
  • Documentation update (changes to README, guides, etc.)
  • CI (updates to continuous integration workflows)
  • Revert (undo a previous commit or merge)

Testing

Demo

-Before :

before.mp4

After :

after.mp4

Environment and Dependencies

  • New Dependencies:
  • Configuration Changes:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added corresponding tests
  • I have run the build command to ensure there are no build errors
  • My changes have been tested across relevant browsers/devices
  • For UI changes, I've included visual evidence of my changes

Copilot AI review requested due to automatic review settings February 23, 2026 10:15
@kilo-code-bot
Copy link

kilo-code-bot bot commented Feb 23, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

This PR adds hover underline styling to the "Resources" navigation button, following the same pattern already used for "Tech" and "Community" buttons. The implementation is clean and consistent with the existing codebase.

Changes:

  • Added linkHoverResources state to track hover status
  • Updated onMouseEnter/onMouseLeave handlers to toggle the state
  • Applied conditional underline styling via className
Files Reviewed (1 file)
  • components/navbar/FloatingNavbarClient.tsx - No issues

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an inconsistency in the desktop navbar by adding the missing underline hover styling to the Resources menu item, bringing it in line with Technology and Community.

Changes:

  • Introduced linkHoverResources state to track hover for the Resources trigger.
  • Updated Resources trigger mouse handlers and classes to apply the underline hover styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: vasu kamani <vasukamani.ce@gmail.com>
@dhananjay6561
Copy link
Contributor

Hi @vasu-CE
Thanks for the PR and for spotting this!

The change fixes a very minor UI issue (Resources tab hover underline). Since the scope of this PR is quite small, we’d recommend exploring a slightly broader improvement or addressing a larger issue and including this fix as part of that update.

Looking forward to seeing more from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Inconsistent Hover Underline on Navbar “Resources” Item

3 participants