fix: add hover effect for resources link in navbar#329
fix: add hover effect for resources link in navbar#329vasu-CE wants to merge 2 commits intokeploy:mainfrom
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR adds hover underline styling to the "Resources" navigation button, following the same pattern already used for "Tech" and "Community" buttons. The implementation is clean and consistent with the existing codebase. Changes:
Files Reviewed (1 file)
|
There was a problem hiding this comment.
Pull request overview
This PR fixes an inconsistency in the desktop navbar by adding the missing underline hover styling to the Resources menu item, bringing it in line with Technology and Community.
Changes:
- Introduced
linkHoverResourcesstate to track hover for the Resources trigger. - Updated Resources trigger mouse handlers and classes to apply the underline hover styling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: vasu kamani <vasukamani.ce@gmail.com>
7a2c885 to
1c9fb61
Compare
|
Hi @vasu-CE The change fixes a very minor UI issue (Resources tab hover underline). Since the scope of this PR is quite small, we’d recommend exploring a slightly broader improvement or addressing a larger issue and including this fix as part of that update. Looking forward to seeing more from you! |
Related Tickets & Documents
Fixes keploy/keploy#3744
Description
Previously, the "Resources" menu item did not display the underline hover effect, while "Technology" and "Community" worked correctly. This caused inconsistent UI behavior across the navigation bar.
The fix ensures that the "Resources" item now follows the same hover styling logic, maintaining visual consistency across all navbar items.
Changes
Added missing hover underline styling to the "Resources" navbar item
Type of Change
Testing
Demo
-Before :
before.mp4
After :
after.mp4
Environment and Dependencies
Checklist