Conversation
Signed-off-by: vasu kamani <vasukamani.ce@gmail.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR makes minor styling improvements to the navbar component:
All changes are straightforward CSS/styling adjustments with no functional or security concerns. Files Reviewed (1 file)
|
7a7c2a9 to
e2e0e04
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses a UI issue in the floating navbar where the Keploy logo was getting clipped during the “shrink on scroll” transition by adjusting the logo container’s overflow behavior.
Changes:
- Updated the logo link/container overflow from
hiddentovisibleto prevent corner clipping during transitions. - Adjusted responsive visibility for the
GitHubStarselement (now shown fromlginstead ofmd).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <div className="hidden lg:flex lg:border-2 lg:border-orange-400/80 rounded-full"> | ||
| <GitHubStars /> |
There was a problem hiding this comment.
The change from hidden md:flex to hidden lg:flex for the GitHubStars container hides the stars button on medium breakpoints (md) and only shows it on large (lg+) screens. This behavior change isn’t described in the PR description (which focuses on the logo clipping), and it may be an unintended responsive regression—please either revert this breakpoint change or document/justify the new md behavior (and ensure it matches the intended design).
|
Hi @vasu-CE . |
ui: For UI/design changes or improvements
Related Tickets & Documents
Fixes keploy/keploy/3427
Description
The new navbar shrinks on scroll, and the Keploy logo scales down accordingly — which is the expected behavior.
However, during the shrink transition, the logo gets cut from the corners due to incorrect dimension handling. This results in partial visibility of the logo instead of maintaining its full proportions.
Changes
Type of Change
Testing
Demo
Before :

After :

Environment and Dependencies
Checklist