Fix re-subscription logic from pipeline services #1266
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenySadadia
force-pushed
the
remove-resubscription-logic
branch
from
51df4b9 to
63010dc
Compare
JenySadadia
changed the title
JenySadadia
force-pushed
the
remove-resubscription-logic
branch
2 times, most recently
from
d30f1c0 to
f3114ac
Compare
When API helper functions `receive_event_node` or `receive_event_data` fails, there may be some issue with extracting node data from the event rather than an issue with the subscription. Check exception message before resubscribing. Fixes: f04f6d0 ("(events): Add re-subscribe mechanism") Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
remove-resubscription-logic
branch
from
f3114ac to
373ef73
Compare
JenySadadia
added
the
staging-skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When API helper functions
receive_event_nodeorreceive_event_datafail, there may be some issue with extracting node data from the event rather than an issue with the subscription.Check exception message before resubscribing.
Fixes: f04f6d0 ("(events): Add re-subscribe mechanism")